Skip to content

Conversation

@perrynzhou
Copy link

@perrynzhou perrynzhou commented Jun 5, 2019

@jsquyres @rhc54 @ggouaillardet sorry, I send pr make a wrong branch to merge with the first time. I already rename dev branch to fixed_atoi_bug.please check it and review code,thank you. detail discuss about link #6735 ,related issue #6729

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@ggouaillardet
Copy link
Contributor

@perryn please squash both commits into one

@perryn
Copy link

perryn commented Jun 5, 2019

Heh. I think you meant to mention @perrynzhou . I was very confused for a second there :)

@perrynzhou
Copy link
Author

second

@perryn I'm sure, the second merge is right.now I just merge commit into one

@ggouaillardet
Copy link
Contributor

yep, thanks for the correction and sorry for the confusion.

perrynzhou added 3 commits June 5, 2019 13:01
Signed-off-by: perrynzhou <[email protected]>

fixed orted double free or corruption
just a one-off commit for the release branches for v4.0.x

Signed-off-by: perrynzhou <[email protected]>

fixed orted double free or corruption
@perrynzhou
Copy link
Author

yep, thanks for the correction and sorry for the confusion.
@ggouaillardet already squash both commits into one, #6738 about details

@ggouaillardet
Copy link
Contributor

I issued #6739 for that purpose (single signed-off commit with a note in the commit message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants