Skip to content

Conversation

@rhc54
Copy link
Contributor

@rhc54 rhc54 commented Jun 28, 2015

When building --no-ompi, we don't run setup_cxx and hence sizeof_bool never gets set. So set it in configure.ac so everyone always has it

@jsquyres please review

… never gets set. So set it in configure.ac so everyone always has it
@rhc54 rhc54 added the bug label Jun 28, 2015
@rhc54 rhc54 added this to the Future milestone Jun 28, 2015
@mellanox-github
Copy link

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/678/

@jsquyres
Copy link
Member

@rhc54 I don't think this is right -- we can't set the language to C++ since we haven't setup the C++ compiler.

I think we should probably just add _Bool to the SIZEOF's that start at configure.ac:378. Additionally, per our conversation last week, should configure.ac:422 be changed to:

OPAL_C_GET_ALIGNMENT(_Bool, OPAL_ALIGNMENT_BOOL)

(i.e., _Bool vs. bool)

This would allow us to get right of the <stdbool.h> in the alignment test.

@rhc54
Copy link
Contributor Author

rhc54 commented Jun 29, 2015

Tried that and got error - you need c++ to get sizeof bool

May have to bring back the opal bottom code in configure

Sent from my iPhone

On Jun 29, 2015, at 9:30 AM, Jeff Squyres [email protected] wrote:

@rhc54 I don't think this is right -- we can't set the language to C++ since we haven't setup the C++ compiler.

I think we should probably just add _Bool to the SIZEOF's that start at configure.ac:378. Additionally, per our conversation last week, should configure.ac:422 be changed to:

OPAL_C_GET_ALIGNMENT(_Bool, OPAL_ALIGNMENT_BOOL)
(i.e., _Bool vs. bool)

This would allow us to get right of the <stdbool.h> in the alignment test.


Reply to this email directly or view it on GitHub.

@rhc54 rhc54 closed this Jun 29, 2015
@rhc54 rhc54 deleted the topic/configure branch June 29, 2015 20:24
jsquyres pushed a commit to jsquyres/ompi that referenced this pull request Nov 10, 2015
…g-libtool-fix

v2.0.0: patch generated configure to fix an other libtool bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants