Ensure we always set sizeof_bool #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… never gets set. So set it in configure.ac so everyone always has it Check for sizeof(_Bool) so we don't need the C++ compiler
|
Refer to this link for build results (access rights to CI server needed): |
rhc54
pushed a commit
that referenced
this pull request
Jun 29, 2015
Ensure we always set sizeof_bool
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
…mory-leak pml/ob1: Fix a memory leak regarding pending FIN control messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building --no-ompi, we don't run setup_cxx and hence sizeof_bool never gets set. So set it in configure.ac so everyone always has it
Check for sizeof(_Bool) so we don't need the C++ compiler
@jsquyres This should make you happy! We may also need this in 2.x as I think (but don't clearly recall) we moved the stdbool.h changes over there.