-
Notifications
You must be signed in to change notification settings - Fork 929
Fix mmap infinite recurse in memory patcher #6855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the indentation changes 👍.
|
@hppritcha Cray CI's git seems to have gone off the rails -- can you please fix? |
|
@hkuno Can you squash down to one commit? Then this PR will be good to go. |
|
had to fix up some things at nersc after upgrade to CLE 7 |
This commit fixes issue #6853 by removing MacOS/Darwin-specific logic from intercept_mmap. It also opportunistically converts tabs to spaces. Signed-off-by: Harumi Kuno <[email protected]>
Sure! I have done that. (Please let me know if the commit message is too terse, and I'll add more detail.) Thank you! |
|
well there was another thing with our jenkins slave prepper installing an old autotools package. try again. bot:ompi:retest |
|
This PR also needs to be cherry-picked over to v4.0.x as it repairs #6720, which introduced an issue this PR addresses. Also needs to be patched in to v3.1.x and v3.0.x. |
|
I'm just browsing this since I added the #6720 that introduced the problem by turning on the interception of mmap that had been considered unnecessary up till that point. I agree with this fix. |
This commit fixes issue #6853 by commenting out lines in configure.m4
that define HAVE___MMAP, avoiding infinite recursion.
This commit also opportunistically converts tabs to spaces.
Signed-off-by: Harumi Kuno [email protected]