Skip to content

Conversation

@hkuno
Copy link
Contributor

@hkuno hkuno commented Jul 30, 2019

This commit fixes issue #6853 by commenting out lines in configure.m4
that define HAVE___MMAP, avoiding infinite recursion.
This commit also opportunistically converts tabs to spaces.

Signed-off-by: Harumi Kuno [email protected]

Copy link
Member

@hjelmn hjelmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the indentation changes 👍.

@jsquyres
Copy link
Member

@hppritcha Cray CI's git seems to have gone off the rails -- can you please fix?

Caused by: hudson.plugins.git.GitException: Command "git init /global/homes/h/hpp/jenkins_cori/workspace/open-mpi.build.platforms/Platform/cray_cle/src" returned status code 127:
stdout: 
stderr: git: error while loading shared libraries: libcrypto.so.0.9.8: cannot open shared object file: No such file or directory

	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2042)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2010)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2006)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1638)
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:811)
	... 12 more

@jsquyres
Copy link
Member

@hkuno Can you squash down to one commit? Then this PR will be good to go.

@hppritcha
Copy link
Member

had to fix up some things at nersc after upgrade to CLE 7
bot:ompi:retest

This commit fixes issue #6853 by removing
MacOS/Darwin-specific logic from intercept_mmap.
It also opportunistically converts tabs to spaces.

Signed-off-by: Harumi Kuno <[email protected]>
@hkuno
Copy link
Contributor Author

hkuno commented Aug 1, 2019

@hkuno Can you squash down to one commit? Then this PR will be good to go.

Sure! I have done that. (Please let me know if the commit message is too terse, and I'll add more detail.) Thank you!

@hppritcha
Copy link
Member

well there was another thing with our jenkins slave prepper installing an old autotools package. try again.

bot:ompi:retest

@hppritcha
Copy link
Member

hppritcha commented Aug 26, 2019

This PR also needs to be cherry-picked over to v4.0.x as it repairs #6720, which introduced an issue this PR addresses. Also needs to be patched in to v3.1.x and v3.0.x.

@hppritcha hppritcha merged commit 71e1fad into open-mpi:master Aug 26, 2019
@markalle
Copy link
Contributor

I'm just browsing this since I added the #6720 that introduced the problem by turning on the interception of mmap that had been considered unnecessary up till that point. I agree with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants