osc/ucx: Fix error path #6893
Merged
osc/ucx: Fix error path #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomislav Janjusic <[email protected]>
brminich
reviewed
Aug 12, 2019
| if (OMPI_SUCCESS != ret) { | ||
| OSC_UCX_VERBOSE(1, "opal_progress_register failed: %d", ret); | ||
| goto error; | ||
| goto select_unlock; |
There was a problem hiding this comment.
could just remove this line, you would end up in select_unlock anyway
There was a problem hiding this comment.
@brminich :) I thought about doing it, but then I thought, what if code for whatever reason is added in between, this error path may go unchecked. Maybe for clarity I prefer to leave it unless there are strong feelings to remove it and rely on fallthrough.
brminich
approved these changes
Aug 12, 2019
artpol84
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing error path change in: #6754 (6678ac0)
Signed-off-by: Tomislav Janjusic [email protected]