Refs open-mpi/ompi#627. Fix support for multi-threads with CUDA 7.0 #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opal/mca/common/cuda/common_cuda.c
Outdated
There was a problem hiding this comment.
Do you want to change this VERBOSE output to say memCtx to match the variable name? I ask because you're making a distinction between ctx and memCtx in the code, so since this is assumedly a debugging output, it might be good to have the output match the variable name.
There was a problem hiding this comment.
Yes, I will make that change. Thanks.
rolfv
force-pushed
the
pr/fix-thread-issue
branch
from
64d917d to
8cc6bef
Compare
|
Fixed the issues and pushed the changes. Do you want to look once more Jeff? If not, then I will just merge when all the automatic tests complete. Thanks Jeff for the review. |
rolfv
pushed a commit
that referenced
this pull request
Aug 10, 2015
Refs #627. Fix support for multi-threads with CUDA 7.0
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
btl/openib: add support for mlx5 atomic operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for threads and CUDA 7.0 was broken. This fixes it. We still need to check for the current context and set it if it is not set.
@jsquyres Can you review? I know you have no expertise here, but just look at the logic. There are slightly different code paths when we can get multiple attributes and when we cannot. Prior to this change, we did not check for current context when we had multiple attribute support. It turns out we have to regardless.