Add wait_sync_global_wakeup() to Qthreads and Argobots threading MCA #8479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
janciesko
force-pushed
the
wait_sync_global_wakeup
branch
from
6325165 to
ce3ed4d
Compare
|
ok to test |
hppritcha
reviewed
Mar 2, 2021
|
Copyrights updated. |
abouteiller
approved these changes
Mar 9, 2021
|
I did not test with argobots or qthreads, but the code looks alright. I'll update the readme and whitelist, since now these should work as intented with FT. |
|
@janciesko can you rebase and squash while adding the --signoff? |
|
@janciesko ping please sign off and rebase if you want this in master and 5.0.x |
janciesko
force-pushed
the
wait_sync_global_wakeup
branch
2 times, most recently
from
49b2c6b to
6dbde5d
Compare
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
janciesko
force-pushed
the
wait_sync_global_wakeup
branch
from
3d73762 to
6dbde5d
Compare
Update copyright information. Signed-off-by: Jan Ciesko <[email protected]>
janciesko
force-pushed
the
wait_sync_global_wakeup
branch
from
6dbde5d to
cc16959
Compare
|
Rebased to master. |
hppritcha
approved these changes
Mar 31, 2021
Conflicts resolved: opal/mca/threads/argobots/threads_argobots_wait_sync.c opal/mca/threads/argobots/threads_argobots_wait_sync.h Signed-off-by: Jan Ciesko <[email protected]>
janciesko
force-pushed
the
wait_sync_global_wakeup
branch
from
deb1087 to
1c8ed58
Compare
|
Rebased to master which includes #8767. |
|
We still need this PR as otherwise QThreads will fail. |
|
Closing in favor of #8790. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opal/mca/threads: Add wait_sync_global_wakeup implementation to Qthreads and Argobots