opal/mca/threads: fix Argobots support [5.0.x] #9375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"opal_list.h" happens to be included by "tsd.h" in mca/threads when a thread type is POSIX, but "mca/threads/threads.h" of other thread types do indirectly not include tsd.h and thus no "opal_list.h". "pmix_internal.h" directly uses opal_list_item_t and thus should include "opal_list.h" in its header. Signed-off-by: Shintaro Iwasaki <[email protected]> (cherry picked from commit 8baab96)
Signed-off-by: Shintaro Iwasaki <[email protected]> (cherry picked from commit 43c21f4)
Argobots 1.1 started to support static mutex/cond initialization. This patch introduces them to clean up the current implementation. Signed-off-by: Shintaro Iwasaki <[email protected]> (cherry picked from commit 8500fc4)
This patch removes unused variables and types. Signed-off-by: Shintaro Iwasaki <[email protected]> (cherry picked from commit f26eb9b)
Signed-off-by: Shintaro Iwasaki <[email protected]> (cherry picked from commit 0be6865)
hppritcha
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #8767 to v5.0.x