Skip to content

Commit b31e751

Browse files
committed
CI check for outdated bindings stub files
1 parent 3fafd4b commit b31e751

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

.github/workflows/build_and_test.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,14 @@ jobs:
6161
docker run --rm \
6262
roboplan_ubuntu:${{ steps.sanitize_tag.outputs.tag }} \
6363
/bin/bash -c './scripts/run_tests.bash'
64+
- name: Check bindings stubs
65+
run: |
66+
if ! git diff --exit-code -- 'bindings/src/roboplan/roboplan_ext/*.pyi'; then
67+
echo "::error The .pyi stub files are out of sync with the source code. Make sure to rebuild the bindings without symlink builds."
68+
echo "Git Diff:"
69+
git diff -- 'bindings/src/roboplan/roboplan_ext/*.pyi'
70+
exit 1
71+
fi
6472
6573
# Build ROS docker images and run tests.
6674
ros_build_and_test:

bindings/src/roboplan/roboplan_ext/core.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class JointConfiguration:
1818

1919
@property
2020
def joint_names(self) -> list[str]:
21-
"""The names of the joints."""
21+
"""The names of the joints. CHANGED!"""
2222

2323
@joint_names.setter
2424
def joint_names(self, arg: Sequence[str], /) -> None: ...

bindings/src/roboplan/roboplan_ext/rrt.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class RRTOptions:
2525
def __init__(self, group_name: str = '', max_nodes: int = 1000, max_connection_distance: float = 3.0, collision_check_step_size: float = 0.05, goal_biasing_probability: float = 0.15, max_planning_time: float = 0.0, rrt_connect: bool = False) -> None: ...
2626

2727
@property
28-
def group_name(self) -> str:
28+
def group_name_bad(self) -> str:
2929
"""The joint group name to be used by the planner."""
3030

3131
@group_name.setter

0 commit comments

Comments
 (0)