feat: add namespace support to Rego driver via input.review.namespaceObject by JaydipGabani · Pull Request #646 · open-policy-agent/frameworks

JaydipGabani · 2025-12-05T06:05:05Z

Add Namespace field to ReviewCfg for passing namespace data to drivers
Add reviews.Namespace() option function for callers to pass namespace
Update Rego driver to accept namespace in toParsedInput and pass to Query
Update hookModuleRego to include input.namespace for Rego policy access
Add TemplateCheckNamespace for testing namespace-based policies
Add WantEnvironment constraint argument for namespace tests
Add TestClient_Review_Namespace e2e test for Rego namespace support

This enables Rego policies to access namespace metadata via input.namespace for namespace-scoped policy decisions.

- Add Namespace field to ReviewCfg for passing namespace data to drivers - Add reviews.Namespace() option function for callers to pass namespace - Update Rego driver to accept namespace in toParsedInput and pass to Query - Update hookModuleRego to include input.namespace for Rego policy access - Add TemplateCheckNamespace for testing namespace-based policies - Add WantEnvironment constraint argument for namespace tests - Add TestClient_Review_Namespace e2e test for Rego namespace support This enables Rego policies to access namespace metadata via input.namespace for namespace-scoped policy decisions. Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

Copilot

Pull request overview

This PR adds namespace support to the Rego driver, enabling Rego policies to access namespace metadata via input.namespace for namespace-scoped policy decisions.

Adds Namespace field to ReviewCfg and a reviews.Namespace() option function for passing namespace data to drivers
Updates Rego driver to include namespace in the input passed to policies via object.get(input, "namespace", null)
Adds comprehensive test coverage with TemplateCheckNamespace and TestClient_Review_Namespace

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
constraint/pkg/client/template_client_test.go	Minor comment punctuation fix
constraint/pkg/client/template_client.go	Minor comment punctuation fix
constraint/pkg/client/reviews/review_opts.go	Adds `Namespace` field to `ReviewCfg` and `Namespace()` option function
constraint/pkg/client/e2e_test.go	Adds end-to-end test for namespace support with multiple test cases
constraint/pkg/client/drivers/rego/rego.go	Updates hook module to include namespace in input using `object.get()`
constraint/pkg/client/drivers/rego/driver.go	Updates `toParsedInput()` to accept and pass namespace parameter
constraint/pkg/client/clienttest/templates.go	Adds `TemplateCheckNamespace` for testing namespace-based policies
constraint/pkg/client/clienttest/cts/constraints.go	Adds `WantEnvironment()` constraint argument helper
constraint/pkg/client/client.go	Reorders imports to follow Go conventions (alphabetical within groups)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

constraint/pkg/client/e2e_test.go

constraint/pkg/client/reviews/review_opts.go

codecov-commenter · 2025-12-05T06:19:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.33%. Comparing base (76869f8) to head (8e4f824).
⚠️ Report is 148 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #646       +/-   ##
===========================================
- Coverage   54.68%   43.33%   -11.35%     
===========================================
  Files          71       97       +26     
  Lines        5241     5411      +170     
===========================================
- Hits         2866     2345      -521     
- Misses       2073     2763      +690     
- Partials      302      303        +1

Flag	Coverage Δ
unittests	`43.33% <ø> (-11.35%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

constraint/pkg/client/clienttest/templates.go

constraint/pkg/client/e2e_test.go

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

constraint/pkg/client/clienttest/templates.go

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

constraint/pkg/client/drivers/rego/rego.go

constraint/pkg/client/drivers/rego/driver.go

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

sozercan

a few minor comments, otherwise lgtm

sozercan · 2025-12-08T20:58:21Z

constraint/pkg/client/clienttest/templates.go

+
+violation[{"msg": msg}] {
+  # Check if namespace is provided and has the expected label
+  ns := input.review.namespaceObject


do we need the guard if object doesn't have namespace?

added the check, if its nil then the variable results in undefined. So it should be alright, but added the check regardless.

sozercan · 2025-12-08T21:01:05Z

constraint/pkg/client/e2e_test.go

+	}{
+		{
+			name:        "no namespace provided - expects violation for missing namespace",
+			namespace:   nil,


can you add a case for empty namespace too

added a test for this.

sozercan · 2025-12-08T21:09:43Z

constraint/pkg/client/e2e_test.go

+			name:        "no namespace provided - expects violation for missing namespace",
+			namespace:   nil,
+			wantEnv:     "production",
+			wantResults: 1,


do we want this to be 0 or 1?

Not really, the test policy is written so that it will result in violation when namespace is nil or empty.

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sozercan

LGTM, thanks

Copilot AI review requested due to automatic review settings December 5, 2025 06:05

Copilot started reviewing on behalf of JaydipGabani December 5, 2025 06:05 View session

Copilot finished reviewing on behalf of JaydipGabani December 5, 2025 06:07

JaydipGabani force-pushed the fix#3777 branch from c927057 to 6a1f9a8 Compare December 5, 2025 06:10

Copilot AI reviewed Dec 5, 2025

View reviewed changes

constraint/pkg/client/e2e_test.go Outdated Show resolved Hide resolved

constraint/pkg/client/reviews/review_opts.go Outdated Show resolved Hide resolved

updating input.namespace to input.review.namespaceObject

7268285

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

JaydipGabani requested a review from Copilot December 6, 2025 01:12

Copilot started reviewing on behalf of JaydipGabani December 6, 2025 01:12 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

constraint/pkg/client/clienttest/templates.go Outdated Show resolved Hide resolved

constraint/pkg/client/e2e_test.go Outdated Show resolved Hide resolved

addressing copilot feedbacl

f656fff

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

JaydipGabani requested a review from Copilot December 6, 2025 01:35

Copilot started reviewing on behalf of JaydipGabani December 6, 2025 01:35 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

constraint/pkg/client/clienttest/templates.go Outdated Show resolved Hide resolved

constraint/pkg/client/clienttest/templates.go Show resolved Hide resolved

Addressing copilot comments

7099316

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

JaydipGabani requested a review from Copilot December 6, 2025 01:57

Copilot started reviewing on behalf of JaydipGabani December 6, 2025 01:57 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

constraint/pkg/client/drivers/rego/rego.go Show resolved Hide resolved

constraint/pkg/client/drivers/rego/driver.go Outdated Show resolved Hide resolved

refactoring setting namespace

1223dc4

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

sozercan reviewed Dec 8, 2025

View reviewed changes

adding tests

caacf32

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>

JaydipGabani requested review from Copilot and sozercan December 9, 2025 06:32

Copilot started reviewing on behalf of JaydipGabani December 10, 2025 00:21 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

JaydipGabani changed the title ~~feat: add namespace support to Rego driver via input.namespace~~ feat: add namespace support to Rego driver via input.review.namespaceObject Dec 17, 2025

Merge branch 'master' into fix#3777

8e4f824

sozercan approved these changes Dec 17, 2025

View reviewed changes

JaydipGabani merged commit e3880ce into open-policy-agent:master Dec 17, 2025
8 checks passed

JaydipGabani deleted the fix#3777 branch December 17, 2025 21:42

Conversation

JaydipGabani commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sozercan left a comment

Choose a reason for hiding this comment

Uh oh!

sozercan Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

JaydipGabani Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

sozercan Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

JaydipGabani Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

sozercan Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

JaydipGabani Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sozercan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Dec 5, 2025 •

edited

Loading