Skip to content

fix: move enum validation to items level for v1alpha1 operations field #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaydipGabani merged 2 commits into from
Mar 12, 2026
Merged

fix: move enum validation to items level for v1alpha1 operations field #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e85df
fix: move enum validation to items level for v1alpha1 operations field
JaydipGabani Mar 9, 2026
d4a829d
Merge branch 'master' into fix/v1alpha1-operations-enum
JaydipGabani Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions constraint/config/crds/templates.gatekeeper.sh_constrainttemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,14 @@ spec:
type: string
type: array
operations:
enum:
- '*'
- CREATE
- DELETE
- UPDATE
- CONNECT
items:
description: OperationType specifies an operation for a request.
enum:
- '*'
- CREATE
- DELETE
- UPDATE
- CONNECT
type: string
type: array
rego:
Expand Down
12 changes: 6 additions & 6 deletions constraint/deploy/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,14 +257,14 @@ spec:
type: string
type: array
operations:
enum:
- '*'
- CREATE
- DELETE
- UPDATE
- CONNECT
items:
description: OperationType specifies an operation for a request.
enum:
- '*'
- CREATE
- DELETE
- UPDATE
- CONNECT
type: string
type: array
rego:
Expand Down
2 changes: 1 addition & 1 deletion constraint/pkg/apis/templates/v1alpha1/constrainttemplate_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ type Target struct {
// +listMapKey=engine
Code []Code `json:"code,omitempty"`

// +kubebuilder:validation:Enum="*";CREATE;DELETE;UPDATE;CONNECT
// +kubebuilder:validation:items:Enum=*;CREATE;DELETE;UPDATE;CONNECT
Operations []admissionv1.OperationType `json:"operations,omitempty"`
}

Expand Down
Loading