workflows: Fix YAML indentation in pylint.yml - #967
Merged
Conversation
Fix indentation issues in the GitHub Actions pylint workflow file: - Replace tabs with spaces for consistent formatting - Correct indentation in the 'on:' trigger section - Ensure proper 2-space YAML indentation throughout This fixes YAML parsing errors that would prevent the workflow from running correctly. Signed-off-by: Praveen K Pandey <praveen@linux.ibm.com>
Add pylint configuration file to disable style/convention checks that are not critical while keeping important error checks enabled. This configuration: - Disables style issues (naming, docstrings, line length, etc.) - Disables refactoring suggestions (too-many-*, complexity, etc.) - Disables false positive errors (dynamic attributes, imports, etc.) - Keeps real bugs enabled (undefined variables, syntax errors, etc.) - Focuses on code correctness over style consistency The goal is to make pylint pass in CI while allowing the codebase to maintain its current style and gradually improve over time. Signed-off-by: Praveen K Pandey <praveen@linux.ibm.com>
Fix critical pylint E0601 errors where variables were used before being assigned in all code paths. Crashtool.py: - Initialize required_pkgs to empty list - Add else clause to handle unknown distros gracefully - Log warning and return early for unsupported distros GcovSetup.py: - Add missing import for OpTestError - Initialize src_path to None before conditional assignment - Raise OpTestError for unsupported distros SecureBoot.py: - Initialize part_list to empty list before conditional assignment - Ensures variable is defined even if skipTest is called TrustedBoot.py: - Initialize part_list to empty list before conditional assignment - Ensures variable is defined even if skipTest is called These fixes ensure all variables are properly initialized before use, preventing potential runtime errors and making the code more robust. Signed-off-by: Praveen K Pandey <praveen@linux.ibm.com>
PraveenPenguin
force-pushed
the
fix_pylint
branch
from
June 9, 2026 08:10
a682e0e to
a36ac62
Compare
Collaborator
Author
|
as this pylint fix .. Accpeting changes in priority |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix indentation issues in the GitHub Actions pylint workflow file:
This fixes YAML parsing errors that would prevent the workflow from running correctly.