Fix Python attributes #103
Merged
+73
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iyán Méndez Veiga <[email protected]>
iyanmv
force-pushed
the
fix-attributes
branch
from
a4c6789 to
d5effde
Compare
ctypes.Structure.__init__() initializes attributes using the list _fields_. However, these are empty because this happens before native().OQS_SIG_new() or native().OQS_KEM_new() are called. The dict self.details was showing correct values by reading and decoding directly from self._sig/self._kem. However, all the other public attributes like self.method_name, self.alg_version or the keys and signature lengths were incorrect. Either None or 0 depending on the ctype defined in _fields_. Instead, let's manually populate all relevant attributes from _fields_ after OQS_SIG_new() or OQS_KEM_new() are called, and let's use those values to create the dict self.details. Signed-off-by: Iyán Méndez Veiga <[email protected]>
Signed-off-by: Iyán Méndez Veiga <[email protected]>
iyanmv
force-pushed
the
fix-attributes
branch
from
d5effde to
59a5ad2
Compare
vsoftco
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctypes.Structure.__init__()initializes the attributes using the list_fields_. However, this happens beforenative().OQS_SIG_new()is called. As a result, many attributes are eitherNoneor0.I propose we manually populate the attributes from
self._sig, and then we use these values to construct the dictself.details.I also add a small unit test to check that Python attributes work.
If you like this approach I can complete this PR by fixingKeyEncapsulationattributes as well.Fixes: #102