-
Notifications
You must be signed in to change notification settings - Fork 654
Fix small README issues #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix small README issues #2323
Conversation
Signed-off-by: prismaman <[email protected]>
Signed-off-by: prismaman <[email protected]>
9a8dc84 to
0d99a48
Compare
|
I am the author of the algorithm support table. Thank you for catching this issue and proposing a contribution! Unfortunately this fix is not sufficient. The algorithm support table in the top-level Please let me know if you need help. Cheers. |
|
Didn't catch the README was generated, was just a quick PR from skimming all the available libs so didn't get further into it than README and src dir. I do feel responsible now for a proper fix, will ping you when the work's done. Thanks for the catch! |
Instead of removing the spec_data from FIPS 205 (it is more correct than the way the link is already embedded in the documentation from PQClean), I wrote a tiny function that attempts to format the hyperlink as to only cover the word NIST/IRTF/ISO Signed-off-by: prismaman <[email protected]>
Signed-off-by: prismaman <[email protected]>
This reverts commit c5ff714. Signed-off-by: prismaman <[email protected]>
xuganyu96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
This PR fixes tiny issues with the README.md file I just spotted while checking out PQ-libraries.
-> No AI has been used for this tiny fix.