Re-produce ML-KEM integration #2325
Open
+2,332
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
…nctions Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
…uld expand into the complete "dst: src" mapping even when a "copies_key" is used [skip-ci] Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
…, compiler options, include directories, link libraries, and CUDA_ARCHITECTURES. Still need testing. Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
src/kem/ml_kem/CMakeLists.txt can build and pass some basic pytest tests on my development machine Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
…at oqsbuild loading Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
…ss efforts Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
list file, source files, and header files uses almost identical API Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
file, but cannot generate architecture flags Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
architecture-level flags Signed-off-by: Ganyu (Bruce) Xu <[email protected]>
baentsch
approved these changes
Nov 29, 2025
Member
baentsch
left a comment
baentsch
left a comment
There was a problem hiding this comment.
LGTM: Thanks for the explanations by documentation @xuganyu96 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements enough OQS Builder features and
oqsbuildfile.ymlcontent to reproduce ML-KEM integrations, including:src/kem/ml_kemsrc/kem/ml_kem/CMakeLists.txtfileThe result builds successfully on my development machine and passes local unit tests.