fix(deps): upgrade ajv from v6 to v8 to resolve ReDoS vulnerability#977
Open
cryptodev-2s wants to merge 1 commit intoopen-rpc:masterfrom
Open
fix(deps): upgrade ajv from v6 to v8 to resolve ReDoS vulnerability#977cryptodev-2s wants to merge 1 commit intoopen-rpc:masterfrom
cryptodev-2s wants to merge 1 commit intoopen-rpc:masterfrom
Conversation
BREAKING CHANGE: `ErrorObject.dataPath` is renamed to `ErrorObject.instancePath` in ajv v8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 528 532 +4
Branches 136 136
=========================================
+ Hits 528 532 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ajvfrom^6.10.0to^8.18.0to fix moderate severity ReDoS vulnerability GHSA-2g4f-4pwh-qvx6ajv-formats@^3.0.1(formats were extracted to a separate package in v8)Changes
package.jsonajv^6.10.0→^8.18.0, addajv-formatsvalidate-open-rpc-document.tsaddFormats(), setstrict: false(needed for draft-07 styleadditionalItemsin@json-schema-tools/meta-schema)method-call-validator.tsAjv as IAjv→Ajv(v8 type export), addaddFormats()parameter-validation-error.test.tsdataPath→instancePathin mockErrorObjectBreaking change
ErrorObject.dataPathwas renamed toErrorObject.instancePathin ajv v8. Downstream code accessing error object properties directly will need to update.Test plan