Skip to content

fix(error handling): give e.message by default #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shanejonas wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(error handling): give e.message by default #246

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af7fab9
fix(error handling): give e.message by default
shanejonas Feb 8, 2020
578d97d
Merge branch 'master' into fix/error-handling-default-emessage
shanejonas Mar 13, 2020
dde8eed
Merge branch 'master' into fix/error-handling-default-emessage
BelfordZ Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class Router {
if (e instanceof JSONRPCError) {
return { error: { code: e.code, message: e.message, data: e.data } };
}
return { error: { code: 6969, message: "unknown error" } };
return { error: { code: 6969, message: e.message } };
Copy link
Member Author

@shanejonas shanejonas Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this could be

{
   error: {
     code: 6969,
     message: "unknown error",
     data: {
       message: e.message
     }
   }
}

Copy link
Member

@BelfordZ BelfordZ Mar 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if its not a JSON RPC error, then its an internal error, and we should not leak internal errors to the API user.

}
}

Expand Down