refactor: replace config-driven Exception with typed HttpException hierarchy#227
Open
refactor: replace config-driven Exception with typed HttpException hierarchy#227
Conversation
…erarchy
Introduces a two-tier error system:
- HttpException base class (statusCode, type, publish) for known HTTP errors
- 11 named subclasses (RuntimeNotFoundException, ExecutionTimeoutException, etc.) as self-documenting throw sites
- Generic \Exception falls through to the error handler as a masked 500 and is always published
- Removes the old constants + Config::load('errors') indirection entirely
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces the framework's generic Utopia\Http\Exception with our own GeneralRouteNotFoundException so the two-tier error handler sees an HttpException and returns the correct 404. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpExceptionbase class withstatusCode,type,publish, andprevious— no Config lookup, everything self-containedRuntimeNotFoundException,ExecutionTimeoutException, etc.) replace the old string-constant system, making throw sites self-documentingHttpExceptioninstances are exposed as-is (respectingpublish); any other\Exceptionis masked as a 500 and always publishedRuntimeConflictExceptionandRuntimeFailedExceptionsetpublish: false; everything else defaults totrueapp/config/errors.phpand theConfig::load('errors')indirection entirelyTest plan
type,message, and status code in responsegeneral_unknown500publish: falseexceptions (runtime conflict, runtime failed) are not forwarded to logger🤖 Generated with Claude Code