Skip to content

Fix popup blocker preventing access to schedule links #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iosifidis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix popup blocker preventing access to schedule links #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75862d8
Fixed the pop-up block
iosifidis Jan 6, 2026
35d6106
Merge pull request #1 from iosifidis/dev
iosifidis Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 91 additions & 82 deletions src/components/MenuBox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,52 +48,61 @@ import { motion } from "framer-motion";
import { useMemo } from "react";
import { useNavigate } from "react-router";
import { DiagonalRightArrowIcon, RightArrowIcon } from "../assets/icons";
import { useDepName, useDepartments } from "../hooks";
import { useDepName, useDepartments, useScheduleData } from "../hooks";
import i18n from "../i18n";

export default function MenuBox({ category }) {
const { title, iconSVG, route, span, isExternal, requireSelection,englishRoute } =
category;
const { title, iconSVG, route, span, isExternal, requireSelection, englishRoute } =
category;
const { depName, depCode } = useDepName();
const departments = useDepartments();

const toast = useToast();
const isDisabled =
requireSelection && (!depCode || !departments.some((dep) => dep.code === depCode));
requireSelection && (!depCode || !departments.some((dep) => dep.code === depCode));
const rotateIn = useMemo(
() => ({
initial: {
rotateX: "180deg",
opacity: 0,
() => ({
initial: {
rotateX: "180deg",
opacity: 0,
},
inView: {
rotateX: "0deg",
opacity: isDisabled ? 0.6 : 1,
transition: {
duration: 0.45,
ease: "easeIn",
},
inView: {
rotateX: "0deg",
opacity: isDisabled ? 0.6 : 1,
transition: {
duration: 0.45,
ease: "easeIn",
},
},
}),
[isDisabled]
},
}),
[isDisabled]
);

const scheduleData = useScheduleData(depCode);
const navigate = useNavigate();

const handleNavigation = () => {
if (route === "/semesterschedule" && scheduleData?.semester) {
window.open(scheduleData.semester, "_blank");
return;
}
if (route === "/examschedule" && scheduleData?.exam) {
window.open(scheduleData.exam, "_blank");
return;
}

if(i18n.language === 'en' && englishRoute){
if (i18n.language === 'en' && englishRoute) {
isExternal
? requireSelection
? window.location.replace(englishRoute, "_blank")
: window.open(englishRoute, "_blank")
: navigate(englishRoute);
}else{
? requireSelection
? window.location.replace(englishRoute, "_blank")
: window.open(englishRoute, "_blank")
: navigate(englishRoute);
} else {
isExternal
? requireSelection
? window.location.replace(route, "_blank")
: window.open(route, "_blank")
: navigate(route);
? requireSelection
? window.location.replace(route, "_blank")
: window.open(route, "_blank")
: navigate(route);
}
};

Expand All @@ -118,59 +127,59 @@ export default function MenuBox({ category }) {


return (
<GridItem
as={motion.div}
// force remount for isDisabled to take effect (framer motion quirk)
key={`${title}-isDisabled-${isDisabled}`}
variants={rotateIn}
viewport={{ once: true }}
cursor="pointer"
onClick={handleSelection}
colSpan={span}
role={"group"}
border="2px"
display="flex"
flexDirection="column"
alignItems="center"
justifyContent="space-between"
borderColor={useColorModeValue("#0050e0", "#f3f3f3")}
backgroundColor={useColorModeValue("#0050e0", "transparent")}
className={`menu-box span-${span}`}
rounded="0.75rem"
p={{ sm: 2, md: 4, lg: 6 }}
whileHover={{ scale: 1.05, boxShadow: "0px 0px 8px rgba(0, 0, 0, 0.3)" }}>
<Flex
w="100%"
flexDirection="row"
alignItems="center"
justifyContent="space-between">
<Box
minW={{ sm: "24px", md: "48px", lg: "52px" }}
maxW={{ sm: "24px", md: "48px", lg: "52px" }}
className={`svg-container ${useColorModeValue(
"light-mode-svg",
"dark-mode-svg"
)}`}>
{iconSVG}
</Box>
<Box
minW={{ sm: "12px", md: "24px", lg: "28px" }}
maxW={{ sm: "12px", md: "24px", lg: "28px" }}
className={`svg-container ${useColorModeValue(
"light-mode-svg",
"dark-mode-svg"
)}`}>
{isExternal ? <DiagonalRightArrowIcon /> : <RightArrowIcon />}
</Box>
</Flex>
<Heading
fontSize={{ sm: 11.95, md: 16, lg: 26, xl: 32 }}
color="#f3f3f3"
w="100%"
fontWeight={500}
fontFamily="Syne">
{title}
</Heading>
</GridItem>
<GridItem
as={motion.div}
// force remount for isDisabled to take effect (framer motion quirk)
key={`${title}-isDisabled-${isDisabled}`}
variants={rotateIn}
viewport={{ once: true }}
cursor="pointer"
onClick={handleSelection}
colSpan={span}
role={"group"}
border="2px"
display="flex"
flexDirection="column"
alignItems="center"
justifyContent="space-between"
borderColor={useColorModeValue("#0050e0", "#f3f3f3")}
backgroundColor={useColorModeValue("#0050e0", "transparent")}
className={`menu-box span-${span}`}
rounded="0.75rem"
p={{ sm: 2, md: 4, lg: 6 }}
whileHover={{ scale: 1.05, boxShadow: "0px 0px 8px rgba(0, 0, 0, 0.3)" }}>
<Flex
w="100%"
flexDirection="row"
alignItems="center"
justifyContent="space-between">
<Box
minW={{ sm: "24px", md: "48px", lg: "52px" }}
maxW={{ sm: "24px", md: "48px", lg: "52px" }}
className={`svg-container ${useColorModeValue(
"light-mode-svg",
"dark-mode-svg"
)}`}>
{iconSVG}
</Box>
<Box
minW={{ sm: "12px", md: "24px", lg: "28px" }}
maxW={{ sm: "12px", md: "24px", lg: "28px" }}
className={`svg-container ${useColorModeValue(
"light-mode-svg",
"dark-mode-svg"
)}`}>
{isExternal ? <DiagonalRightArrowIcon /> : <RightArrowIcon />}
</Box>
</Flex>
<Heading
fontSize={{ sm: 11.95, md: 16, lg: 26, xl: 32 }}
color="#f3f3f3"
w="100%"
fontWeight={500}
fontFamily="Syne">
{title}
</Heading>
</GridItem>
);
}