Conversation
…all angle tests locally
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 79.86% 79.88% +0.02%
==========================================
Files 93 93
Lines 7448 7447 -1
==========================================
+ Hits 5948 5949 +1
+ Misses 1500 1498 -2
|
| @@ -1,5 +1,5 @@ | |||
| /// Apache License 2.0 | |||
|
|
|||
| #include <cmath> | |||
There was a problem hiding this comment.
Simply for consistency:
| #include <cmath> | |
| #include <cmath> | |
There was a problem hiding this comment.
| const Real adjestedRangeValue = aRangeLowerBound + excessValue; | |
| const Real adjustedRangeValue = aRangeLowerBound + excessValue; |
There was a problem hiding this comment.
| if ((adjestedRangeValue >= aRangeLowerBound) && (adjestedRangeValue < aRangeUpperBound)) | |
| if ((adjustedRangeValue >= aRangeLowerBound) && (adjustedRangeValue < aRangeUpperBound)) |
There was a problem hiding this comment.
| return adjestedRangeValue; | |
| return adjustedRangeValue; |
There was a problem hiding this comment.
No need for an else block, since the if block returns.
There was a problem hiding this comment.
Comment block style is likely different from the rest of the codebase?
vishwa2710
left a comment
vishwa2710
left a comment
There was a problem hiding this comment.
Just some nits. yeah I agree this is a bit gross :/ let me think if there's a better way to deal with the rounding issues.
| return false; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
| } | ||
|
|
||
| return this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit); | ||
| return (this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit)); |
There was a problem hiding this comment.
| return (this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit)); | |
| return this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit); |
| ); | ||
| } | ||
| // this line handles some rounding error albeit in a way that doesnt pass the smell test... | ||
| Real value = aValue + 10.0 - 10.0; |
There was a problem hiding this comment.
| Real value = aValue + 10.0 - 10.0; | |
| const Real value = aValue + 10.0 - 10.0; |
3 participants
No description provided.