Skip to content

Feat: keep up with ts version#25

Merged
ningkaiqiang merged 6 commits intomainfrom
feat-linear-damping
Apr 6, 2025
Merged

Feat: keep up with ts version#25
ningkaiqiang merged 6 commits intomainfrom
feat-linear-damping

Conversation

@ningkaiqiang
Copy link
Collaborator

@ningkaiqiang ningkaiqiang self-assigned this Apr 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.82%. Comparing base (f56e448) to head (3134333).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/FSRS/Algorithm/FSRSAlgorithm.swift 95.12% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   89.56%   89.82%   +0.26%     
==========================================
  Files          11       11              
  Lines        1054     1101      +47     
==========================================
+ Hits          944      989      +45     
- Misses        110      112       +2     
Flag Coverage Δ
unittests 89.82% <96.55%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
}

w = w.enumerated().map({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var w = defaultW

Swift arrays are value types or reference types? If they are reference types, will the operation var w = defaultW affect defaultW? There is currently a bug in ts-fsrs that will corrupt default_w.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Swift, this won't affect defaultW.

Copy link
Member

@ishiko732 ishiko732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningkaiqiang ningkaiqiang merged commit 642799c into main Apr 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants