Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 89.56% 89.82% +0.26%
==========================================
Files 11 11
Lines 1054 1101 +47
==========================================
+ Hits 944 989 +45
- Misses 110 112 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ishiko732
reviewed
Apr 5, 2025
| } | ||
| } | ||
|
|
||
| w = w.enumerated().map({ |
Member
There was a problem hiding this comment.
var w = defaultWSwift arrays are value types or reference types? If they are reference types, will the operation var w = defaultW affect defaultW? There is currently a bug in ts-fsrs that will corrupt default_w.
Collaborator
Author
There was a problem hiding this comment.
In Swift, this won't affect defaultW.
L-M-Sherlock
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: wrong elapsed days
feat: add next state
feat: clamp params and s