[exporter/elasticsearch] Serialize the @timestamp field for metrics as a number
#41811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as a number This improves the ingestion performance in Elasticsearch as it can leverage an optimized code path for date parsing. See elastic/elasticsearch#132462 This is not a breaking change because we are using the `date` field type for metrics. Supporting a more granular date format, such as `date_nanos` doesn't seem sensible for metrics as it would cause a big storage overhead. Most other metrics data stores also don't support more granularity than milliseconds.
carsonip
reviewed
Aug 6, 2025
Co-authored-by: Carson Ip <[email protected]>
carsonip
approved these changes
Aug 6, 2025
atoulme
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the ingestion performance in Elasticsearch as it can leverage an optimized code path for date parsing.
See elastic/elasticsearch#132462
This is not a breaking change because we are using the
datefield type for metrics. Supporting a more granular date format, such asdate_nanosdoesn't seem sensible for metrics as it would cause a big storage overhead. Most other metrics data stores also don't support more granularity than milliseconds.