Skip to content

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Oct 15, 2025

Description

#43509 changed the make for-all Makefile target to access the ALL_MODS variable through environment variables instead of expanding it into the shell command, in order to bypass Windows' 8192 byte command line length limit.

However, the environment variable was not defined, which led to make for-all becoming a no-op. This can be confirmed by running make for-all CMD='echo test'.

(I discovered this issue because this PR in core repository, which should be failing contrib-tests, suddenly started passing them. This was because the job inserts replace statements in a copy of contrib using for-all; failing to do that caused the contrib tests to run against whatever version of core is imported here rather than against the PR's code.)

This PR fixes that oversight, by adding the export keyword to the ALL_MODS variable.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code is out of date, please run "make generate" and commit the changes in this PR.

@jade-guiton-dd
Copy link
Contributor Author

jade-guiton-dd commented Oct 15, 2025

It looks like make generate (and the CI that uses it) uses make for-all, so they haven't been working either. I'll run it to catch up.

@jade-guiton-dd
Copy link
Contributor Author

I think it should be ready to merge now

@songy23 songy23 merged commit 8abefcc into open-telemetry:main Oct 15, 2025
186 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants