[chore] Fix make for-all command #43572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#43509 changed the
make for-all
Makefile target to access theALL_MODS
variable through environment variables instead of expanding it into the shell command, in order to bypass Windows' 8192 byte command line length limit.However, the environment variable was not defined, which led to
make for-all
becoming a no-op. This can be confirmed by runningmake for-all CMD='echo test'
.(I discovered this issue because this PR in core repository, which should be failing
contrib-tests
, suddenly started passing them. This was because the job insertsreplace
statements in a copy of contrib usingfor-all
; failing to do that caused the contrib tests to run against whatever version of core is imported here rather than against the PR's code.)This PR fixes that oversight, by adding the
export
keyword to theALL_MODS
variable.