[reveicer/prometheusreceiver] Add feature gate for extra scrape metrics in Prometheus receiver #44539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs in Prometheus receiver
fr0stylo
requested review from
a team,
ArthurSens and
dashpole
as code owners
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
ArthurSens
reviewed
Nov 26, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Nice, thanks for working on this. Should we also update our README file?
receiver/prometheusreceiver/metrics_receiver_report_extra_scrape_metrics_test.go
Outdated
Show resolved
Hide resolved
.chloggen/feat_prometheusreceiver-featuregate-extrascrapemetrics.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Arthur Silva Sens <[email protected]>
…eMetrics` feature gate in Prometheus receiver
Contributor
Author
|
Resolved comments and updated README.md |
ArthurSens
reviewed
Nov 26, 2025
… in favor of `EnableReportExtraScrapeMetrics` feature gate
Contributor
Author
|
README.md updated |
Contributor
|
Thank you for your contribution @fr0stylo! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add feature gate for extra scape metrics in prometheus receiver along side current configuration. Change should not change any current behavior, just adds new additional input stream, which needs to be migrated later
Link to tracking issue
Fixes #44181
Testing
Updated tests to support mainly new input - feature gate, due to the fact of deprecation of configuration setup