[connector/count] Fix regression in basic config behavior #44540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue for details.
TLDR:
countrelies onUnmarshalto set default subconfigs, but this update changed confmap behavior to NOT call unmarshal for nil subconfigs like this one whichcountexpects to work:so no metrics are emitted, even though this is a basic example of usage from the readme.
A workaround is to set this instead:
but I think it's better to match the previous behavior by setting the default configs with
createDefaultConfigand just overriding them inUnmarshalif custom metrics are defined.Link to tracking issue
Fixes 41769
Testing
Documentation
N/A, this fix makes the behavior match documentation again.