Skip to content

Conversation

@ArthurSens
Copy link
Member

In #44447 we covered more lines of code in our tests, but we did so by adding more untested code 😅

Since the new fakeMetadataStore is only used for tests, I'm moving it to a test file

Signed-off-by: Arthur Silva Sens <[email protected]>
@ArthurSens ArthurSens requested review from a team and dashpole as code owners November 27, 2025 12:42
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Nov 27, 2025
@ArthurSens
Copy link
Member Author

If you have the time, please let me know what you think @RealAnna :)

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense 🙂

@ArthurSens ArthurSens added the ready to merge Code review completed; ready to merge by maintainers label Nov 28, 2025
@codeboten codeboten merged commit 10c1e40 into open-telemetry:main Nov 28, 2025
207 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/prometheus Prometheus receiver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants