-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Upgrade uses of configgrpc/confighttp #44591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade uses of configgrpc/confighttp #44591
Conversation
|
Pinging Sumologic extension code owners: @rnishtala-sumo @chan-tim-sumo @amdprophet The I tried adding a call to
|
|
After the last commit, the scoped tests failed twice, but because of flaky tests that seem unrelated to the changes, so I'm marking this ready for review. I have no idea why changing |
mx-psi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to merge before scoped tests pass since this is a PR against another PR
3e38397
into
open-telemetry:otelbot/update-otel-1764244003
Description
Follow up to open-telemetry/opentelemetry-collector#14190, which introduced an API breaking change: instead of passing a
host component.Hosttoconfiggrpcandconfighttp'sToClient/ToServermethods, components should instead pass the result ofhost.GetComponents(). Tests that don't make use of authentication or middleware extensions, as well as custom component hosts which don't support extensions (such as the OpAMP supervisor), can simply pass nil instead of using a no-op host.Replacing
hostbyhost.GetComponents()is fairly straightforward, as long as you don't pass in anilhost, which unfortunately a lot of tests do, so I had to fix that as well.This will be merged into the update-otel PR at #44581.