[mdatagen] Improve validation for attribute enabled field
#13921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource attributes now require an explicit `enabled` field in metadata.yaml files, while regular attributes are prohibited from having this field. This improves validation and prevents configuration errors.
dmitryax
force-pushed
the
control-attribute-enabled
branch
from
6d92750 to
04bb6d9
Compare
|
Failing contrib tests catch missing enabled field on the resource attributes. I'll fix them there |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (20.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13921 +/- ##
==========================================
- Coverage 91.68% 91.66% -0.02%
==========================================
Files 652 652
Lines 42506 42516 +10
==========================================
+ Hits 38972 38973 +1
- Misses 2728 2734 +6
- Partials 806 809 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Sep 30, 2025
If enabled is unset in metadata.yaml it's defaulted to false. This commit doesn't change any behavior, it only unblocks the stricter validation open-telemetry/opentelemetry-collector#13921 by setting the false value explicitly Likely the enabled fields are missed by mistake here. If so, they should be explicitly fixed separately.
|
Submitted a PR to fix contrib tests open-telemetry/opentelemetry-collector-contrib#43085 |
songy23
approved these changes
Sep 30, 2025
dmitryax
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Sep 30, 2025
If `enabled` is unset in metadata.yaml defaults to false. This commit doesn't change any behavior, it only unblocks the stricter validation open-telemetry/opentelemetry-collector#13921 by setting the false value explicitly. Likely the enabled fields are missed by mistake here. If so, they should be explicitly fixed separately, cc (code owners of the effected components) @nslaughter, @celian-garcia, @ishleenk17, @Caleb-Hurshman, @mrsillydog.
Merged
via the queue into
open-telemetry:main
with commit Sep 30, 2025
3484f81
61 of 63 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource attributes now require an explicit
enabledfield in metadata.yaml files, while regular attributes are prohibited from having this field. This improves validation and prevents configuration errors.Brought from discussion in #13900
Fixes #12722