Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .chloggen/consumererror_partial_success.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: consumererror

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add new partial error type to consumererror to allow consumers to report partial successes.

# One or more tracking issues or pull requests related to the change
issues: [13423]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
44 changes: 44 additions & 0 deletions consumer/consumererror/partial.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this in xconsumererror at the start, use it in contrib and once we are confident about it we move it to the 'stable' module

Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

package consumererror // import "go.opentelemetry.io/collector/consumer/consumererror"

import "errors"

type partialError struct {
inner error
failed int
}

var _ error = partialError{}

func (pe partialError) Error() string {
return pe.inner.Error()
}

func (pe partialError) Unwrap() error {
return pe.inner
}

func (pe partialError) Failed() int {
return pe.failed
}

// NewPartial creates a new partial error. This is used by consumers
// to report errors where only a subset of the total items failed
// to be written, but it is not possible to tell which particular items
// failed.
func NewPartial(err error, failed int) error {
return NewPermanent(partialError{
inner: err,
failed: failed,
})
}

// AsPartial checks if an error was wrapped with the NewPartial function,
// or if it contains one such error in its Unwrap() tree.
func AsPartial(err error) (partialError, bool) {

Check failure on line 40 in consumer/consumererror/partial.go

View workflow job for this annotation

GitHub Actions / CodeQL-Build

unexported-return: exported func AsPartial returns unexported type consumererror.partialError, which can be annoying to use (revive)

Check failure on line 40 in consumer/consumererror/partial.go

View workflow job for this annotation

GitHub Actions / lint

unexported-return: exported func AsPartial returns unexported type consumererror.partialError, which can be annoying to use (revive)
var pe partialError
ok := errors.As(err, &pe)
return pe, ok
}
22 changes: 22 additions & 0 deletions consumer/consumererror/partial_test.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a testable example on how to use this?

Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

package consumererror

import (
"errors"
"testing"

"github.com/stretchr/testify/assert"
)

func TestPartial(t *testing.T) {
internalErr := errors.New("some points failed")
err := NewPartial(internalErr, 5)
assert.True(t, IsPermanent(err))
partialErr, ok := AsPartial(err)
assert.True(t, ok)
assert.Equal(t, 5, partialErr.Failed())
assert.Equal(t, internalErr, partialErr.Unwrap())
assert.Equal(t, internalErr.Error(), partialErr.Error())
}
Loading