Skip to content

Conversation

mahadzaryab1
Copy link
Contributor

Description

  • This PR fixes the helpers for AnyValue by changing the API to accept pcommon.Value. Since otlpcommon.AnyValue is an internal type, the current helpers are not useful as a public API.

Link to tracking issue

Fixes #13837 (original issue #12826)

Testing

  • Updated unit tests

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review October 7, 2025 21:06
@mahadzaryab1 mahadzaryab1 requested review from a team, bogdandrutu and dmitryax as code owners October 7, 2025 21:06
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.63%. Comparing base (6cd9c4e) to head (81fa069).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pdata/xpdata/json.go 83.33% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13945      +/-   ##
==========================================
- Coverage   91.67%   91.63%   -0.04%     
==========================================
  Files         654      654              
  Lines       42658    42659       +1     
==========================================
- Hits        39106    39091      -15     
- Misses       2738     2750      +12     
- Partials      814      818       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu
Copy link
Member

dmathieu commented Oct 9, 2025

Could you add a changelog entry?

@mahadzaryab1
Copy link
Contributor Author

Could you add a changelog entry?

@dmathieu Done!

change_type: 'enhancement'

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: 'xpdata'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: #13993

@mahadzaryab1
Copy link
Contributor Author

@dmathieu is this PR good to go?

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
@dmathieu
Copy link
Member

It needs review/merge by a maintainer.

@bogdandrutu bogdandrutu added this pull request to the merge queue Oct 13, 2025
Merged via the queue into open-telemetry:main with commit a96eab1 Oct 13, 2025
70 of 75 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 13, 2025
Copy link
Contributor

otelbot bot commented Oct 13, 2025

Thank you for your contribution @mahadzaryab1! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants