-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix Helpers For Marshalling And Unmarshalling pcommon.Value #13945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Helpers For Marshalling And Unmarshalling pcommon.Value #13945
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13945 +/- ##
==========================================
- Coverage 91.67% 91.63% -0.04%
==========================================
Files 654 654
Lines 42658 42659 +1
==========================================
- Hits 39106 39091 -15
- Misses 2738 2750 +12
- Partials 814 818 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Could you add a changelog entry? |
@dmathieu Done! |
.chloggen/fix-anyvalue-json.yaml
Outdated
change_type: 'enhancement' | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
component: 'xpdata' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: #13993
@dmathieu is this PR good to go? |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
214687a
to
81fa069
Compare
It needs review/merge by a maintainer. |
a96eab1
Thank you for your contribution @mahadzaryab1! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Description
pcommon.Value
. Sinceotlpcommon.AnyValue
is an internal type, the current helpers are not useful as a public API.Link to tracking issue
Fixes #13837 (original issue #12826)
Testing