[configoptional] Add support for setting an 'enabled' field under a feature gate #13995
+229
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13995 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 654 654
Lines 42659 42671 +12
=======================================
+ Hits 39100 39112 +12
Misses 2744 2744
Partials 815 815 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
changed the title
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
| component: config/configoptional |
There was a problem hiding this comment.
This should be 'all' to pass the component list test (see this thread)
| addEnabledFieldFeatureGateID, | ||
| featuregate.StageAlpha, | ||
| featuregate.WithRegisterFromVersion("v0.138.0"), | ||
| featuregate.WithRegisterDescription("Allows optional fields to be configured via an 'enabled' field."), |
There was a problem hiding this comment.
Nitpick: s/configured/toggled/ may be clearer?
| component: config/configoptional | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Adds new `configoptional.AddEnabledField` feature gate that allows user to decide `configoptional` flavor through a new `enabled` field |
There was a problem hiding this comment.
Nitpick: "Flavor" is more of an internal term, maybe "allows users to explicitly disable a configoptional.Optional through a new enabled field"?
yurishkuro
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for disabling or enabling optional fields through an
enabledkey under an alpha feature gate,configoptional.AddEnabledField. For example, the following configuration becomes valid:and is equivalent to:
Link to tracking issue
Fixes #13894
Updates #14021