Add Unwrap method on tracer provider wrapper and use it in zpagesextension #14006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-guiton-dd
added
the
Skip Changelog
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14006 +/- ##
==========================================
- Coverage 91.67% 91.65% -0.02%
==========================================
Files 654 654
Lines 42659 42659
==========================================
- Hits 39107 39100 -7
- Misses 2738 2744 +6
- Partials 814 815 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axw
reviewed
Oct 14, 2025
Comment on lines
54
to
57
| // If the TracerProvider was wrapped by the service implementation, access the underlying SDK provider | ||
| if wrapped, ok := tp.(interface{ Unwrap() trace.TracerProvider }); ok { | ||
| tp = wrapped.Unwrap() | ||
| } |
There was a problem hiding this comment.
Should this be a for loop, like in errors.Is? i.e. keep unwrapping until we reach one without an Unwrap method?
There was a problem hiding this comment.
Yes, that would make sense. Done.
jade-guiton-dd
requested review from
a team,
dmathieu and
mx-psi
as code owners
mx-psi
approved these changes
Oct 14, 2025
Merged
via the queue into
open-telemetry:main
with commit Oct 14, 2025
5bdfd09
59 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows components to access SDK-specific
TracerProvidermethods (inzpagesextension's case,RegisterSpanProcessor), without requiringcomponentattributeto have a dependency on the official SDK.This is an alternative proposal to #13947
Link to tracking issue
Updates #13842
Testing
Should be covered by
TestServiceTelemetryZPages. (In fact the "missing coverage" should be covered by that test as well, but it's in another module.)