Skip to content

Conversation

@iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Oct 28, 2025

Continuation #13106

  • Added Profiles.MergeTo implementation that merges one profile message into another while reconciling their dictionaries and appending
    resource profiles.
    • Added comprehensive unit tests covering both the successful merge path and error propagation when dictionary switching fails.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.16%. Comparing base (73f090c) to head (a3051d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14091      +/-   ##
==========================================
+ Coverage   92.10%   92.16%   +0.05%     
==========================================
  Files         667      668       +1     
  Lines       41453    41463      +10     
==========================================
+ Hits        38181    38214      +33     
+ Misses       2227     2215      -12     
+ Partials     1045     1034      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Nov 12, 2025
@dmathieu
Copy link
Member

This can be rebased against the main branch.

@iblancasa iblancasa changed the title Introduce merge to methods for profiles Introduce MergeTo method for profiles Nov 20, 2025
@iblancasa iblancasa marked this pull request as ready for review November 20, 2025 15:59
@iblancasa iblancasa requested review from a team, dmathieu and mx-psi as code owners November 20, 2025 15:59
@iblancasa iblancasa changed the title Introduce MergeTo method for profiles [chore] Introduce MergeTo method for profiles Nov 25, 2025
@iblancasa iblancasa requested a review from dmathieu November 25, 2025 18:34
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 25, 2025

CodSpeed Performance Report

Merging #14091 will not alter performance

Comparing iblancasa:mergeto (a3051d1) with main (73f090c)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 71 untouched

@dmathieu
Copy link
Member

This looks good to me, but why is it a "chore"? It introduces a new public method, it needs a changelog entry.

@iblancasa iblancasa changed the title [chore] Introduce MergeTo method for profiles Introduce MergeTo method for profiles Nov 26, 2025
Signed-off-by: Israel Blancas <[email protected]>
@dmathieu
Copy link
Member

Could you avoid force-pushing PRs? That breaks the GitHub review interface.

@iblancasa iblancasa requested a review from florianl November 27, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants