-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Introduce MergeTo method for profiles #14091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14091 +/- ##
==========================================
+ Coverage 92.10% 92.16% +0.05%
==========================================
Files 667 668 +1
Lines 41453 41463 +10
==========================================
+ Hits 38181 38214 +33
+ Misses 2227 2215 -12
+ Partials 1045 1034 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This can be rebased against the main branch. |
CodSpeed Performance ReportMerging #14091 will not alter performanceComparing
|
|
This looks good to me, but why is it a "chore"? It introduces a new public method, it needs a changelog entry. |
Signed-off-by: Israel Blancas <[email protected]>
|
Could you avoid force-pushing PRs? That breaks the GitHub review interface. |
Signed-off-by: Israel Blancas <[email protected]>
Continuation #13106
Profiles.MergeToimplementation that merges one profile message into another while reconciling their dictionaries and appendingresource profiles.