Skip to content

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Nov 6, 2025

Description

Marks configoptional.AddEnabledField as beta. I have verified that it would work correctly for cookies configuration and made a PoC for keepalives (I will push a PR for it after this PR has been merged).

I spent some time updating open-telemetry/opentelemetry-specification/issues/4344 and filed open-telemetry/opentelemetry-specification/pull/4723 as a way to explicitly state that the guidance only applies to environment variables. The issue remains unresolved, but given the current usages of enabled (see open-telemetry/opentelemetry-specification#4344 (comment)) I don't see a reason to not go forward with this.

Link to tracking issue

Updates #14021

@mx-psi mx-psi marked this pull request as ready for review November 6, 2025 11:28
@mx-psi mx-psi requested a review from a team as a code owner November 6, 2025 11:28
@mx-psi mx-psi requested a review from codeboten November 6, 2025 11:28
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (a6a1766) to head (e6e1a8f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14136      +/-   ##
==========================================
- Coverage   92.25%   92.22%   -0.03%     
==========================================
  Files         657      657              
  Lines       41068    41068              
==========================================
- Hits        37888    37876      -12     
- Misses       2176     2184       +8     
- Partials     1004     1008       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten added this pull request to the merge queue Nov 7, 2025
Merged via the queue into open-telemetry:main with commit 88cb737 Nov 7, 2025
60 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants