-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[configgrpc] Guard OpenTelemetry gRPC instrumentation with a feature gate #14222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[configgrpc] Guard OpenTelemetry gRPC instrumentation with a feature gate #14222
Conversation
CodSpeed Performance ReportMerging #14222 will not alter performanceComparing
|
|
@open-telemetry/semconv-rpc-approvers I would love to have your opinion on this PR. My interpretation of https://opentelemetry.io/blog/2025/stability-proposal-announcement/#instrumentation-and-convention-goals is that this would be fine to have enabled by default, but if you believe it is still early for users to adopt these I would like to hear it |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14222 +/- ##
==========================================
- Coverage 92.15% 92.14% -0.01%
==========================================
Files 667 667
Lines 41446 41449 +3
==========================================
Hits 38194 38194
- Misses 2215 2217 +2
- Partials 1037 1038 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
as long as you're following https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/README.md#semantic-conventions-for-rpc Important Existing RPC instrumentations that are using
|
Description
Guards
otelgrpcinstrumentation behind a newconfiggrpc.useOtelGRPCInstrumentationfeature flag.These are unstable semantic conventions being actively worked on by the RPC Semconv SIG (RPC Semantic Conventions Stability) and the
otelgrpclibrary itself is unstable.I argue this would be beneficial because: