Configure exporter default aggregation and temporality preference #107
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ | |
| "$ref": "#/$defs/OtlpMetric" | ||
| }, | ||
| "console": { | ||
| "$ref": "#/$defs/ConsoleMetric" | ||
| }, | ||
| "prometheus": { | ||
| "$ref": "#/$defs/Prometheus" | ||
|
|
@@ -113,6 +113,9 @@ | |
| }, | ||
| "with_resource_constant_labels": { | ||
| "$ref": "common.json#/$defs/IncludeExclude" | ||
| }, | ||
| "default_aggregation_by_instrument_kind": { | ||
| "$ref": "#/$defs/DefaultAggregationByInstrumentKind" | ||
| } | ||
| } | ||
| }, | ||
|
|
@@ -167,14 +170,10 @@ | |
| "minimum": 0 | ||
| }, | ||
| "temporality_preference": { | ||
| "$ref": "#/$defs/AggregationTemporalityPreference" | ||
| }, | ||
| "default_aggregation_by_instrument_kind": { | ||
| "$ref": "#/$defs/DefaultAggregationByInstrumentKind" | ||
| }, | ||
| "insecure": { | ||
| "type": ["boolean", "null"] | ||
|
|
@@ -186,6 +185,92 @@ | |
| ], | ||
| "title": "OtlpMetric" | ||
| }, | ||
| "AggregationTemporalityPreference": { | ||
|
There was a problem hiding this comment. The spec says that aggregation temporality should be configurable as a function of instrument kind, but most users will want to use these shorthand options. This is much simpler / more compact than writing the preference for each instrument kind. In the future, we can add a separate property to give full control over temporality by instrument kind if needed. |
||
| "type": ["string", "null"], | ||
| "enum": [ | ||
| "delta", | ||
| "cumulative", | ||
| "low_memory" | ||
| ] | ||
| }, | ||
| "DefaultAggregationByInstrumentKind": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "counter": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| }, | ||
| "histogram": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| }, | ||
| "observable_counter": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| }, | ||
| "observable_gauge": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| }, | ||
| "observable_up_down_counter": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| }, | ||
| "up_down_counter": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| } | ||
| } | ||
| }, | ||
| "Aggregation": { | ||
|
There was a problem hiding this comment. Lifting this aggregation type def up from the view stream definition. Its now reused both for view stream config and in exporter default aggregation config. |
||
| "type": ["object", "null"], | ||
| "additionalProperties": false, | ||
| "minProperties": 1, | ||
| "maxProperties": 1, | ||
| "properties": { | ||
| "default": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false | ||
| }, | ||
| "drop": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false | ||
| }, | ||
| "explicit_bucket_histogram": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "boundaries": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "number" | ||
| } | ||
| }, | ||
| "record_min_max": { | ||
| "type": ["boolean", "null"] | ||
| } | ||
| } | ||
| }, | ||
| "base2_exponential_bucket_histogram": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "max_scale": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "max_size": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "record_min_max": { | ||
| "type": ["boolean", "null"] | ||
| } | ||
| } | ||
| }, | ||
| "last_value": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false | ||
| }, | ||
| "sum": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, | ||
| "View": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false, | ||
|
|
@@ -235,58 +320,7 @@ | |
| "type": ["string", "null"] | ||
| }, | ||
| "aggregation": { | ||
| "$ref": "#/$defs/Aggregation" | ||
| }, | ||
| "attribute_keys": { | ||
| "type": "array", | ||
|
|
@@ -297,6 +331,18 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "ConsoleMetric": { | ||
| "type": ["object", "null"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "temporality_preference": { | ||
| "$ref": "#/$defs/AggregationTemporalityPreference" | ||
| }, | ||
| "default_aggregation_by_instrument_kind": { | ||
| "$ref": "#/$defs/DefaultAggregationByInstrumentKind" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if I want to
I see that there is a yaml anchor - but I'm not sure this should be the only option to share values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using anchors makes using the config easier. No need to merge properties from some global exporter config with per-exporter config. And simplifies the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a lesser known and complicated feature