Skip to content

add http known methods #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add http known methods #244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f982250
add http known methods
zeitlinger Jul 11, 2025
58d781a
Merge branch 'main' into http-known-methods
codeboten Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion schema/instrumentation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@
"type": "object",
"additionalProperties": false,
"properties": {
"known_methods": {
"type": "array",
"items": {
"type": "string"
}
},
Comment on lines +91 to +96
Copy link
Member

@trask trask Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be split into the client and server options below

I could almost see this option not being needed on client spans since it is primarily needed for avoiding metric cardinality attacks on servers (but I see we've defined it on both client and server spans in semconv, I don't remember if we discussed this previously, @lmolkova?)

"client": {
"type": "object",
"additionalProperties": false,
Expand Down Expand Up @@ -136,4 +142,4 @@
}
}
}
}
}
Loading