Skip to content

Add Default Histogram Aggregation in prometheus schema #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Default Histogram Aggregation in prometheus schema #99

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de770ec
adds default_histogram_aggregation in prometheus schema
Abhishekkr3003 Jul 2, 2024
6604a34
space correction
Abhishekkr3003 Jul 2, 2024
b41389b
Update schema/meter_provider.json
Abhishekkr3003 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/kitchen-sink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ meter_provider:
# Configure resource attributes to be excluded, in this example attribute service.attr1.
excluded:
- "service.attr1"
default_histogram_aggregation: "base2_exponential_bucket_histogram"
# Configure metric producers.
producers:
# Configure metric producer to be opencensus
Expand Down Expand Up @@ -442,21 +443,21 @@ instrumentation:
# Instrumenation may merge general config options with the language specific configuration at .instrumentation.<language>.
general:
# Configure instrumentations following the peer semantic conventions.
#
#
# See peer semantic conventions: https://opentelemetry.io/docs/specs/semconv/attributes-registry/peer/
peer:
# Configure the service mapping for instrumentations following peer.service semantic conventions.
#
# Each entry is a key value pair where "peer" defines the IP address and "service" defines the corresponding logical name of the service.
#
#
# See peer.service semantic conventions: https://opentelemetry.io/docs/specs/semconv/general/attributes/#general-remote-service-attributes
service_mapping:
- peer: 1.2.3.4
service: FooService
- peer: 2.3.4.5
service: BarService
# Configure instrumentations following the http semantic conventions.
#
#
# See http semantic conventions: https://opentelemetry.io/docs/specs/semconv/http/
http:
# Configure instrumentations following the http client semantic conventions.
Expand Down
7 changes: 7 additions & 0 deletions schema/meter_provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@
},
"with_resource_constant_labels": {
"$ref": "common.json#/$defs/IncludeExclude"
},
"default_histogram_aggregation": {
"type": "string",
"enum": [
"explicit_bucket_histogram",
"base2_exponential_bucket_histogram"
]
}
}
},
Expand Down