Add support for B3Multi headers propagation #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzaxak
force-pushed
the
b3multi-headers-propagation
branch
from
513ef43 to
9e94b3d
Compare
kuzaxak
changed the title
Some services expect [B3 Multi][1] headers as input information. To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy. Tests will be added as a separate commit later on. Solving open-telemetry#36 [1]: https://github.com/openzipkin/b3-propagation#multiple-headers [2]: open-telemetry/opentelemetry-go#765
kuzaxak
force-pushed
the
b3multi-headers-propagation
branch
from
9e94b3d to
1c339b5
Compare
|
@lalitb Hey, could you please have a look and give me quick feedback on this PR. We are using B3Multi headers for historical reasons and would like to add this functionality to the library. |
|
any chances of getting this reviewed/merged? @open-telemetry/cpp-contrib-approvers |
|
@seemk could you please take a look? |
|
Hoping for updates on this, as it's currently forcing us to use opentracing for the time being. |
|
/easycla |
|
Since it has been a while, I've resurrected this PR at #495 Retained your original commits and added a few tests. Closing this one for now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services expect B3 Multi headers as input information.
To support that we need to be able to Inject them into upstream requests.
Tests will be added as a separate commit later on.
Solving #36