Add B3 multi header propagation support #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services expect [B3 Multi][1] headers as input information. To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy. Tests will be added as a separate commit later on. Solving #36 [1]: https://github.com/openzipkin/b3-propagation#multiple-headers [2]: open-telemetry/opentelemetry-go#765
lalitb
reviewed
Dec 4, 2024
lalitb
reviewed
Dec 4, 2024
| if (traceContext == nullptr || !traceContext->request_span) { | ||
| ngx_log_error( | ||
| NGX_LOG_ERR, req->connection->log, 0, | ||
| "Unable to get trace context when getting span id"); |
There was a problem hiding this comment.
nit, can be ignored if doesn't look good -
Suggested change
| "Unable to get trace context when getting span id"); | |
| "Invalid trace context or request span when getting span id"); |
There was a problem hiding this comment.
I've signed the CLA, but for some reason I'm getting an EasyCLA error when pushing to this branch, will change the wording in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #103
I've brought it up to date and added tests, retained the original commits by @kuzaxak