Skip to content

[Geneva] Inlcucde UDS header for Linux only #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[Geneva] Inlcucde UDS header for Linux only #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exporters/geneva/src/exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@

#include "opentelemetry/exporters/geneva/metrics/exporter.h"
#include "opentelemetry/exporters/geneva/metrics/macros.h"
#include "opentelemetry/exporters/geneva/metrics/unix_domain_socket_data_transport.h"
#ifdef _WIN32
#include "opentelemetry/exporters/geneva/metrics/etw_data_transport.h"
#else
#include "opentelemetry/exporters/geneva/metrics/unix_domain_socket_data_transport.h"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, UDS can work on Windows, but I don't think there is any real user scenario. Probably exclude it from Windows build for now.

#endif
#include "opentelemetry/sdk/metrics/export/metric_producer.h"
#include "opentelemetry/sdk_config.h"
Expand Down
Loading