Add SocketDataTransport to support kTCP/kUDP #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurex
force-pushed
the
feature/socket_transport_geneva_exporter
branch
from
fc4ebbc to
019c042
Compare
ThomsonTan
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Looks good to me. Will see if there is any comments from @lalitb.
lalitb
approved these changes
Apr 7, 2025
6 tasks
ThomsonTan
added a commit
to ThomsonTan/opentelemetry-cpp-contrib
that referenced
this pull request
May 9, 2025
)" This reverts commit 2184b83.
ThomsonTan
added a commit
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR raised for fix #536 , navigate to the issue to get more details.
Changes
SocketDataTransportto support UNIX/UDP/TCP protocol.UnixDomainDataTransportsinceSocketDataTransportcovered unix scenario.geneva-exporterto1.0.1.Test && Validation
Existing Behavior
exporteronly supportkETWandkUNIXprotocol although the connection string supportkUDPandkTCP.New Behavior
Support all the protocols which defined in TransportProtocol: