Skip to content

[Geneva] Do not set shutdown on connection failure in initialization #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

[Geneva] Do not set shutdown on connection failure in initialization #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion exporters/geneva/src/exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Exporter::Exporter(const ExporterOptions &options)
auto status = data_transport_->Connect();
if (!status) {
LOG_ERROR("[Geneva Exporter] Connect failed. No data would be sent.");
is_shutdown_ = true;
return;
}
}
Expand Down
2 changes: 1 addition & 1 deletion exporters/geneva/src/socket_data_transport.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ bool SocketDataTransport::Send(MetricsEventType event_type,
"Geneva Exporter: UDS::Send Socket reconnect failed. Send failed");
}
}
if (error_code != 0) {
if (!connected_ || error_code != 0 ) {
LOG_ERROR("Geneva Exporter: UDS::Send failed - not connected");
connected_ = false;
return false;
Expand Down