Skip to content

[Geneva] Send data to socket with MSG_NOSIGNAL #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

[Geneva] Send data to socket with MSG_NOSIGNAL #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion exporters/fluentd/include/opentelemetry/exporters/fluentd/common/socket_tools.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,14 @@ struct Socket {
assert(m_sock != Invalid);
if ((m_sock == Invalid) || (buffer == nullptr) || (size == 0))
return 0;
int flags =
#ifdef _WIN32
0;
#else
MSG_NOSIGNAL;
#endif
return static_cast<int>(
::send(m_sock, reinterpret_cast<char const *>(buffer), size, 0));
::send(m_sock, reinterpret_cast<char const *>(buffer), size, flags));
}

int sendto(void const *buffer, size_t size, int flags, SocketAddr &destAddr) {
Expand Down
8 changes: 7 additions & 1 deletion exporters/geneva/include/opentelemetry/exporters/geneva/metrics/socket_tools.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,8 +570,14 @@ struct Socket {
assert(m_sock != Invalid);
if ((m_sock == Invalid) || (buffer == nullptr) || (size == 0))
return 0;
int flags =
#ifdef _WIN32
0;
#else
MSG_NOSIGNAL;
#endif
return static_cast<int>(
::send(m_sock, reinterpret_cast<char const *>(buffer), size, 0));
::send(m_sock, reinterpret_cast<char const *>(buffer), size, flags));
}

int sendto(void const *buffer, size_t size, int flags, SocketAddr &destAddr) {
Expand Down