Skip to content

Conversation

@ThomsonTan
Copy link
Contributor

This reverts commit 2184b83.

There is no plan to support kTCP/kUDP in the near future. Will log error when these protocols are used.

FYI @zurex

@ThomsonTan ThomsonTan requested a review from a team as a code owner May 9, 2025 01:51
@ThomsonTan ThomsonTan merged commit dcff883 into open-telemetry:main May 9, 2025
2 checks passed
@ThomsonTan ThomsonTan deleted the revert_kTCP branch May 9, 2025 16:38
@malkia
Copy link

malkia commented May 20, 2025

Can anyone explain what happened here? This was added first, then removed, but no further notes about why?

@lalitb
Copy link
Member

lalitb commented May 21, 2025

Can anyone explain what happened here? This was added first, then removed, but no further notes about why?

The exporter in this directory is designed only for sending metrics to a locally running collector agent - so it supports UDS on Linux and ETW on Windows. For sending metrics to remote collector, it’s best to use the standard OTLP exporter.

@ThomsonTan
Copy link
Contributor Author

Can anyone explain what happened here? This was added first, then removed, but no further notes about why?

Yes, as Lalit mentioned, we recommend running this exporter side-by-side with the application. To reduce the confusion, and as mentioned in the revert description, we don't plan to support the remote protocol like TCP or UDP.

I will remove the protocol definition of kTCP and 'kUDP` to make this more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants