[Geneva] Make EXPORT_NAME consistent #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomsonTan
commented
Jun 10, 2025
| "include/opentelemetry/exporters/geneva" | ||
| FILES_DESTINATION | ||
| "include/opentelemetry/exporters/geneva" | ||
| "include/opentelemetry/exporters" |
There was a problem hiding this comment.
The destination path should not include "geneva".
dbarker
reviewed
Jun 10, 2025
| add_subdirectory(example) | ||
| endif() | ||
|
|
||
| if(OPENTELEMETRY_INSTALL) |
There was a problem hiding this comment.
The export name properties are good to set unconditionally. These lines can go immediately after add_library calls for each target.
There was a problem hiding this comment.
Moved it out to be after add_libary().
dbarker
reviewed
Jun 10, 2025
lalitb
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the commend on inconsistent EXPORT_NAME for different build types of the contrib exportes.