Skip to content

resolve socket leak in fluentd exporter #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

resolve socket leak in fluentd exporter #585

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6823050
resolve socket leak in fluentd exporter
KSSKarthikeya Oct 3, 2025
991f0cb
remove unwanted assignments
KSSKarthikeya Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions exporters/fluentd/src/log/fluentd_exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@ bool FluentdExporter::Connect() {
connected_ = socket_.connect(*addr_);
if (!connected_) {
LOG_ERROR("Unable to connect to %s", options_.endpoint.c_str());
// Close the socket to avoid leaking file descriptors on failure.
if (!socket_.invalid()) {
socket_.close();
}
connected_ = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this set of connected_ to false necessary? Seems unnecessary because it is already in false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomsonTan , thanks for pointing that out, I have removed it.
Can this be approved ?

return false;
}
}
Expand Down