Skip to content

Commit 51aae2a

Browse files
committed
fix clang-tidy cppcoreguidelines-explicit-virtual-functions warnings
1 parent d954e2f commit 51aae2a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

exporters/otlp/src/otlp_grpc_client.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class OPENTELEMETRY_LOCAL_SYMBOL OtlpGrpcAsyncCallData : public OtlpGrpcAsyncCal
9191
result_callback;
9292

9393
OtlpGrpcAsyncCallData() {}
94-
virtual ~OtlpGrpcAsyncCallData() {}
94+
~OtlpGrpcAsyncCallData() override {}
9595
};
9696
} // namespace
9797
#endif

exporters/otlp/test/otlp_grpc_log_record_exporter_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class OtlpMockTraceServiceStub : public proto::collector::trace::v1::MockTraceSe
125125
public:
126126
async_interface(OtlpMockTraceServiceStub *owner) : stub_(owner) {}
127127

128-
virtual ~async_interface() override = default;
128+
~async_interface() override = default;
129129

130130
void Export(
131131
::grpc::ClientContext *context,
@@ -188,7 +188,7 @@ class OtlpMockLogsServiceStub : public proto::collector::logs::v1::MockLogsServi
188188
public:
189189
async_interface(OtlpMockLogsServiceStub *owner) : stub_(owner) {}
190190

191-
virtual ~async_interface() override = default;
191+
~async_interface() override = default;
192192

193193
void Export(
194194
::grpc::ClientContext *context,

0 commit comments

Comments
 (0)