Skip to content

Commit d954e2f

Browse files
committed
fix clang-tidy misc-unused-parameters warnings
1 parent 6092c03 commit d954e2f

File tree

1 file changed

+22
-19
lines changed

1 file changed

+22
-19
lines changed

sdk/test/metrics/metric_collector_test.cc

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -46,39 +46,42 @@ namespace
4646

4747
MetricFilter::TestMetricFn AcceptAllTestMetricFn()
4848
{
49-
return [](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
50-
nostd::string_view unit) -> MetricFilter::MetricFilterResult {
49+
return [](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
50+
const InstrumentType & /*type*/,
51+
nostd::string_view /*unit*/) -> MetricFilter::MetricFilterResult {
5152
return MetricFilter::MetricFilterResult::kAccept;
5253
};
5354
}
5455
MetricFilter::TestMetricFn DropAllTestMetricFn()
5556
{
56-
return [](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
57-
nostd::string_view unit) -> MetricFilter::MetricFilterResult {
57+
return [](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
58+
const InstrumentType & /*type*/,
59+
nostd::string_view /*unit*/) -> MetricFilter::MetricFilterResult {
5860
return MetricFilter::MetricFilterResult::kDrop;
5961
};
6062
}
6163
MetricFilter::TestMetricFn AcceptPartialAllTestMetricFn()
6264
{
63-
return [](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
64-
nostd::string_view unit) -> MetricFilter::MetricFilterResult {
65+
return [](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
66+
const InstrumentType & /*type*/,
67+
nostd::string_view /*unit*/) -> MetricFilter::MetricFilterResult {
6568
return MetricFilter::MetricFilterResult::kAcceptPartial;
6669
};
6770
}
6871

6972
MetricFilter::TestAttributesFn AcceptAllTestAttributesFn()
7073
{
71-
return [](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
72-
nostd::string_view unit,
73-
const PointAttributes &attributes) -> MetricFilter::AttributesFilterResult {
74+
return [](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
75+
const InstrumentType & /*type*/, nostd::string_view /*unit*/,
76+
const PointAttributes & /*attributes*/) -> MetricFilter::AttributesFilterResult {
7477
return MetricFilter::AttributesFilterResult::kAccept;
7578
};
7679
}
7780
MetricFilter::TestAttributesFn DropAllTestAttributesFn()
7881
{
79-
return [](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
80-
nostd::string_view unit,
81-
const PointAttributes &attributes) -> MetricFilter::AttributesFilterResult {
82+
return [](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
83+
const InstrumentType & /*type*/, nostd::string_view /*unit*/,
84+
const PointAttributes & /*attributes*/) -> MetricFilter::AttributesFilterResult {
8285
return MetricFilter::AttributesFilterResult::kDrop;
8386
};
8487
}
@@ -194,9 +197,9 @@ TEST_F(MetricCollectorTest, CollectWithMetricFilterTestMetricTest3)
194197
auto meter = std::shared_ptr<Meter>(new Meter(context, std::move(scope)));
195198
context->AddMeter(meter);
196199

197-
auto test_metric_fn = [](const InstrumentationScope &scope, nostd::string_view name,
198-
const InstrumentType &type,
199-
nostd::string_view unit) -> MetricFilter::MetricFilterResult {
200+
auto test_metric_fn = [](const InstrumentationScope & /*scope*/, nostd::string_view name,
201+
const InstrumentType & /*type*/,
202+
nostd::string_view /*unit*/) -> MetricFilter::MetricFilterResult {
200203
std::string name_copy = {name.begin(), name.end()};
201204
if (name_copy.find("_accept") != std::string::npos)
202205
{
@@ -249,8 +252,8 @@ TEST_F(MetricCollectorTest, CollectWithMetricFilterTestAttributesTest1)
249252
context->AddMeter(meter);
250253

251254
auto test_attributes_fn =
252-
[](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
253-
nostd::string_view unit,
255+
[](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
256+
const InstrumentType & /*type*/, nostd::string_view /*unit*/,
254257
const PointAttributes &attributes) -> MetricFilter::AttributesFilterResult {
255258
if (attributes.GetAttributes().find("stream") != attributes.GetAttributes().end())
256259
{
@@ -332,8 +335,8 @@ TEST_F(MetricCollectorTest, CollectWithMetricFilterTestAttributesTest2)
332335
context->AddMeter(meter);
333336

334337
auto test_attributes_fn =
335-
[](const InstrumentationScope &scope, nostd::string_view name, const InstrumentType &type,
336-
nostd::string_view unit,
338+
[](const InstrumentationScope & /*scope*/, nostd::string_view /*name*/,
339+
const InstrumentType & /*type*/, nostd::string_view /*unit*/,
337340
const PointAttributes &attributes) -> MetricFilter::AttributesFilterResult {
338341
if (attributes.GetAttributes().find("stream") != attributes.GetAttributes().end())
339342
{

0 commit comments

Comments
 (0)