fix clang-tidy performance-unnecessary-value-param warnings

dbarker · dbarker · commit 6092c033d25d · 2025-06-24T12:51:19.000-06:00
diff --git a/sdk/src/trace/span.cc b/sdk/src/trace/span.cc
@@ -172,7 +172,7 @@ void Span::AddLinks(const opentelemetry::trace::SpanContextKeyValueIterable &lin
     return;
   }
 
-  links.ForEachKeyValue([&](opentelemetry::trace::SpanContext span_context,
+  links.ForEachKeyValue([&](const opentelemetry::trace::SpanContext &span_context,
                             const common::KeyValueIterable &attributes) {
     recordable_->AddLink(span_context, attributes);
     return true;
diff --git a/sdk/test/metrics/metric_collector_test.cc b/sdk/test/metrics/metric_collector_test.cc
@@ -89,7 +89,7 @@ class testing::MetricCollectorTest : public Test
 {
 public:
   std::weak_ptr<MetricCollector> AddMetricReaderToMeterContext(
-      std::shared_ptr<MeterContext> context,
+      const std::shared_ptr<MeterContext> &context,
       std::shared_ptr<MetricReader> reader,
       std::unique_ptr<MetricFilter> metric_filter = nullptr) noexcept
   {

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ void Span::AddLinks(const opentelemetry::trace::SpanContextKeyValueIterable &lin`
`172`	`172`	`return;`
`173`	`173`	`}`
`174`	`174`
`175`		`- links.ForEachKeyValue([&](opentelemetry::trace::SpanContext span_context,`
	`175`	`+ links.ForEachKeyValue([&](const opentelemetry::trace::SpanContext &span_context,`
`176`	`176`	`const common::KeyValueIterable &attributes) {`
`177`	`177`	`recordable_->AddLink(span_context, attributes);`
`178`	`178`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ class testing::MetricCollectorTest : public Test`
`89`	`89`	`{`
`90`	`90`	`public:`
`91`	`91`	`std::weak_ptr<MetricCollector> AddMetricReaderToMeterContext(`
`92`		`- std::shared_ptr<MeterContext> context,`
	`92`	`+ const std::shared_ptr<MeterContext> &context,`
`93`	`93`	`std::shared_ptr<MetricReader> reader,`
`94`	`94`	`std::unique_ptr<MetricFilter> metric_filter = nullptr) noexcept`
`95`	`95`	`{`